-
-
Notifications
You must be signed in to change notification settings - Fork 762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor tests #1631
Merged
Merged
Refactor tests #1631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 4158240817
💛 - Coveralls |
RobbeSneyders
force-pushed
the
feature/clean-tests
branch
from
February 7, 2023 08:28
34f922d
to
76d48fb
Compare
RobbeSneyders
force-pushed
the
feature/clean-tests
branch
from
February 8, 2023 07:59
76d48fb
to
01fac26
Compare
Ruwann
approved these changes
Feb 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Noticed one typo (that was already there)
Thanks for the hint on the atomic commits, made it very clear actually to go commit by commit
Co-authored-by: Ruwann <ruwanlambrichts@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors our tests to prepare the activation of our tests for our AsyncApp.
The separate commits are atomic, which can be useful for reviewing.